Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 846bf3b8 authored by Eric Biggers's avatar Eric Biggers Committed by Jaegeuk Kim
Browse files

vfs: use READ_ONCE() to access ->i_link 



Use 'READ_ONCE(inode->i_link)' to explicitly support filesystems caching
the symlink target in ->i_link later if it was unavailable at iget()
time, or wasn't easily available.  I'll be doing this in fscrypt, to
improve the performance of encrypted symlinks on ext4, f2fs, and ubifs.

->i_link will start NULL and may later be set to a non-NULL value by a
smp_store_release() or cmpxchg_release().  READ_ONCE() is needed on the
read side.  smp_load_acquire() is unnecessary because only a data
dependency barrier is required.  (Thanks to Al for pointing this out.)

Acked-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent dd038b34

fs/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -1068,7 +1068,7 @@ const char *get_link(struct nameidata *nd) 
		return ERR_PTR(error);



	nd->last_type = LAST_BIND;

	res = inode->i_link;

	res = READ_ONCE(inode->i_link);

	if (!res) {

		const char * (*get)(struct dentry *, struct inode *,

				struct delayed_call *);
@@ -4731,7 +4731,7 @@ int vfs_readlink(struct dentry *dentry, char __user *buffer, int buflen) 
		spin_unlock(&inode->i_lock);

	}



	link = inode->i_link;

	link = READ_ONCE(inode->i_link);

	if (!link) {

		link = inode->i_op->get_link(dentry, inode, &done);

		if (IS_ERR(link))