Commit 8464dd52 authored Sep 18, 2012 by Guennadi Liakhovetski Committed by Chris Ball Oct 03, 2012

mmc: sh-mmcif: avoid oops on spurious interrupts



On some systems, e.g., kzm9g, MMCIF interfaces can produce spurious
interrupts without any active request. To prevent the Oops, that results
in such cases, don't dereference the mmc request pointer until we make
sure, that we are indeed processing such a request.

Reported-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Chris Ball <cjb@laptop.org>

parent 7a7eb328

drivers/mmc/host/sh_mmcif.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1231,6 +1231,10 @@ static irqreturn_t sh_mmcif_intr(int irq, void *dev_id)
		host->sd_error = true;
		dev_dbg(&host->pd->dev, "int err state = %08x\n", state);
		}
		if (host->state == STATE_IDLE) {
		dev_info(&host->pd->dev, "Spurious IRQ status 0x%x", state);
		return IRQ_HANDLED;
		}
		if (state & ~(INT_CMD12RBE \| INT_CMD12CRE)) {
		if (!host->dma_active)
		return IRQ_WAKE_THREAD;