Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8456b99c authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Dave Airlie
Browse files

udl-kms: change down_interruptible to down 



If we leave urbs around, it causes not only leak, but also memory
corruption. This patch fixes the function udl_free_urb_list, so that it
always waits for all urbs that are in progress.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent acb18725

drivers/gpu/drm/udl/udl_main.c

+1 −6
Original line number Diff line number Diff line
@@ -170,18 +170,13 @@ static void udl_free_urb_list(struct drm_device *dev) 
	struct list_head *node;

	struct urb_node *unode;

	struct urb *urb;

	int ret;

	unsigned long flags;



	DRM_DEBUG("Waiting for completes and freeing all render urbs\n");



	/* keep waiting and freeing, until we've got 'em all */

	while (count--) {



		/* Getting interrupted means a leak, but ok at shutdown*/

		ret = down_interruptible(&udl->urbs.limit_sem);

		if (ret)

			break;

		down(&udl->urbs.limit_sem);



		spin_lock_irqsave(&udl->urbs.lock, flags);