Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83ff1953 authored by Sabrina Dubroca's avatar Sabrina Dubroca Committed by Greg Kroah-Hartman
Browse files

selftests: tls: swap the TX and RX sockets in some tests 



[ Upstream commit c326ca98446e0ae4fee43a40acf79412b74cfedb ]

tls.sendmsg_large and tls.sendmsg_multiple are trying to send through
the self->cfd socket (only configured with TLS_RX) and to receive through
the self->fd socket (only configured with TLS_TX), so they're not using
kTLS at all. Swap the sockets.

Fixes: 7f657d5b ("selftests: tls: add selftests for TLS sockets")
Signed-off-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 97ac63b1

tools/testing/selftests/net/tls.c

+4 −4
Original line number Diff line number Diff line
@@ -199,11 +199,11 @@ TEST_F(tls, sendmsg_large) 


		msg.msg_iov = &vec;

		msg.msg_iovlen = 1;

		EXPECT_EQ(sendmsg(self->cfd, &msg, 0), send_len);

		EXPECT_EQ(sendmsg(self->fd, &msg, 0), send_len);

	}



	while (recvs++ < sends) {

		EXPECT_NE(recv(self->fd, mem, send_len, 0), -1);

		EXPECT_NE(recv(self->cfd, mem, send_len, 0), -1);

	}



	free(mem);
@@ -232,9 +232,9 @@ TEST_F(tls, sendmsg_multiple) 
	msg.msg_iov = vec;

	msg.msg_iovlen = iov_len;



	EXPECT_EQ(sendmsg(self->cfd, &msg, 0), total_len);

	EXPECT_EQ(sendmsg(self->fd, &msg, 0), total_len);

	buf = malloc(total_len);

	EXPECT_NE(recv(self->fd, buf, total_len, 0), -1);

	EXPECT_NE(recv(self->cfd, buf, total_len, 0), -1);

	for (i = 0; i < iov_len; i++) {

		EXPECT_EQ(memcmp(test_strs[i], buf + len_cmp,

				 strlen(test_strs[i])),