Commit 83d514d7 authored Jan 12, 2015 by Pali Rohár Committed by Greg Kroah-Hartman Jan 25, 2015

i8k: Return -ENODATA for invalid temperature



Guenter Roeck suggested to return -ENODATA instead -ERANGE or -EINVAL when BIOS
reports invalid temperature value.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 672af223

drivers/char/i8k.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -331,7 +331,7 @@ static int i8k_get_temp(int sensor)
		prev[sensor] = temp;
		}
		if (temp > I8K_MAX_TEMP)
		return -ERANGE;
		return -ENODATA;
		#endif

		return temp;
		@@ -533,8 +533,6 @@ static ssize_t i8k_hwmon_show_temp(struct device *dev,
		int temp;

		temp = i8k_get_temp(index);
		if (temp == -ERANGE)
		return -EINVAL;
		if (temp < 0)
		return temp;
		return sprintf(buf, "%d\n", temp * 1000);