Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 837c4da9 authored by Sara Sharon's avatar Sara Sharon Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: change the check for ADD_STA status 



The firmware will return the baid for BA session in the
ADD_STA command response.
This requires masking the check of the status, which is
actually only 8 bits, and not the whole 32 bits.

Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 1c4e15a2

drivers/net/wireless/intel/iwlwifi/mvm/fw-api-sta.h

+3 −0
Original line number Diff line number Diff line
@@ -253,6 +253,9 @@ struct iwl_mvm_keyinfo { 
	__le64 hw_tkip_mic_tx_key;

} __packed;



#define IWL_ADD_STA_STATUS_MASK	0xFF

#define IWL_ADD_STA_BAID_MASK	0xFF00



/**

 * struct iwl_mvm_add_sta_cmd - Add/modify a station in the fw's sta table.

 * ( REPLY_ADD_STA = 0x18 )

drivers/net/wireless/intel/iwlwifi/mvm/sta.c

+5 −5
Original line number Diff line number Diff line
@@ -192,7 +192,7 @@ int iwl_mvm_sta_send_to_fw(struct iwl_mvm *mvm, struct ieee80211_sta *sta, 
	if (ret)

		return ret;



	switch (status) {

	switch (status & IWL_ADD_STA_STATUS_MASK) {

	case ADD_STA_SUCCESS:

		IWL_DEBUG_ASSOC(mvm, "ADD_STA PASSED\n");

		break;
@@ -362,7 +362,7 @@ int iwl_mvm_drain_sta(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta, 
	if (ret)

		return ret;



	switch (status) {

	switch (status & IWL_ADD_STA_STATUS_MASK) {

	case ADD_STA_SUCCESS:

		IWL_DEBUG_INFO(mvm, "Frames for staid %d will drained in fw\n",

			       mvmsta->sta_id);
@@ -628,7 +628,7 @@ static int iwl_mvm_add_int_sta_common(struct iwl_mvm *mvm, 
	if (ret)

		return ret;



	switch (status) {

	switch (status & IWL_ADD_STA_STATUS_MASK) {

	case ADD_STA_SUCCESS:

		IWL_DEBUG_INFO(mvm, "Internal station added.\n");

		return 0;
@@ -851,7 +851,7 @@ int iwl_mvm_sta_rx_agg(struct iwl_mvm *mvm, struct ieee80211_sta *sta, 
	if (ret)

		return ret;



	switch (status) {

	switch (status & IWL_ADD_STA_STATUS_MASK) {

	case ADD_STA_SUCCESS:

		IWL_DEBUG_INFO(mvm, "RX BA Session %sed in fw\n",

			       start ? "start" : "stopp");
@@ -909,7 +909,7 @@ static int iwl_mvm_sta_tx_agg(struct iwl_mvm *mvm, struct ieee80211_sta *sta, 
	if (ret)

		return ret;



	switch (status) {

	switch (status & IWL_ADD_STA_STATUS_MASK) {

	case ADD_STA_SUCCESS:

		break;

	default: