Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83741bb0 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

bnxt: simplify cls_flower command switch and handle default case 



Currently the default case is not handled, which with future command
introductions would introduce a warning. So handle it and make the
switch a bit simplier removing unneeded "rc" variable.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0ef8b456

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

+5 −11
Original line number Diff line number Diff line
@@ -1544,22 +1544,16 @@ void bnxt_tc_flow_stats_work(struct bnxt *bp) 
int bnxt_tc_setup_flower(struct bnxt *bp, u16 src_fid,

			 struct tc_cls_flower_offload *cls_flower)

{

	int rc = 0;



	switch (cls_flower->command) {

	case TC_CLSFLOWER_REPLACE:

		rc = bnxt_tc_add_flow(bp, src_fid, cls_flower);

		break;



		return bnxt_tc_add_flow(bp, src_fid, cls_flower);

	case TC_CLSFLOWER_DESTROY:

		rc = bnxt_tc_del_flow(bp, cls_flower);

		break;



		return bnxt_tc_del_flow(bp, cls_flower);

	case TC_CLSFLOWER_STATS:

		rc = bnxt_tc_get_flow_stats(bp, cls_flower);

		break;

		return bnxt_tc_get_flow_stats(bp, cls_flower);

	default:

		return -EOPNOTSUPP;

	}

	return rc;

}



static const struct rhashtable_params bnxt_tc_flow_ht_params = {