Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 834e0f8a authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu: validate paramaters in the gem ioctl 



Reject it if there are any invalid flags or domains.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c085bd51

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+21 −0
Original line number Original line Diff line number Diff line
@@ -202,6 +202,27 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data, 
	bool kernel = false;

	bool kernel = false;

	int r;

	int r;





	/* reject invalid gem flags */

	if (args->in.domain_flags & ~(AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED |

				      AMDGPU_GEM_CREATE_NO_CPU_ACCESS |

				      AMDGPU_GEM_CREATE_CPU_GTT_USWC |

				      AMDGPU_GEM_CREATE_VRAM_CLEARED|

				      AMDGPU_GEM_CREATE_SHADOW |

				      AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS)) {

		r = -EINVAL;

		goto error_unlock;

	}

	/* reject invalid gem domains */

	if (args->in.domains & ~(AMDGPU_GEM_DOMAIN_CPU |

				 AMDGPU_GEM_DOMAIN_GTT |

				 AMDGPU_GEM_DOMAIN_VRAM |

				 AMDGPU_GEM_DOMAIN_GDS |

				 AMDGPU_GEM_DOMAIN_GWS |

				 AMDGPU_GEM_DOMAIN_OA)) {

		r = -EINVAL;

		goto error_unlock;

	}



	/* create a gem object to contain this object in */

	/* create a gem object to contain this object in */

	if (args->in.domains & (AMDGPU_GEM_DOMAIN_GDS |

	if (args->in.domains & (AMDGPU_GEM_DOMAIN_GDS |

	    AMDGPU_GEM_DOMAIN_GWS | AMDGPU_GEM_DOMAIN_OA)) {

	    AMDGPU_GEM_DOMAIN_GWS | AMDGPU_GEM_DOMAIN_OA)) {