Commit 8320768d authored May 01, 2019 by Linus Torvalds Committed by Greg Kroah-Hartman Aug 06, 2019

gcc-9: properly declare the {pv,hv}clock_page storage

commit 459e3a21535ae3c7a9a123650e54f5c882b8fcbf upstream.

The pvlock_page and hvclock_page variables are (as the name implies)
addresses to pages, created by the linker script.

But we declared them as just "extern u8" variables, which _works_, but
now that gcc does some more bounds checking, it causes warnings like

warning: array subscript 1 is outside array bounds of ‘u8[1]’

when we then access more than one byte from those variables.

Fix this by simply making the declaration of the variables match
reality, which makes the compiler happy too.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 354887ae

arch/x86/entry/vdso/vclock_gettime.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -29,12 +29,12 @@ extern int __vdso_gettimeofday(struct timeval tv, struct timezone tz);
		extern time_t __vdso_time(time_t *t);

		#ifdef CONFIG_PARAVIRT_CLOCK
		extern u8 pvclock_page
		extern u8 pvclock_page[PAGE_SIZE]
		__attribute__((visibility("hidden")));
		#endif

		#ifdef CONFIG_HYPERV_TSCPAGE
		extern u8 hvclock_page
		extern u8 hvclock_page[PAGE_SIZE]
		__attribute__((visibility("hidden")));
		#endif