Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8304b633 authored by Olof Johansson's avatar Olof Johansson Committed by David S. Miller
Browse files

pasemi_mac: Print warning when not attaching to a PHY 



pasemi_mac: Print warning when not attaching to a PHY

Print a warning on the console when not connecting to a phy for an interface.
It turns out to be a pretty common problem when someone gets the MDIO info
wrong in their device tree, resulting in the macs running at a fixed 1Gbit FD.

Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 5d894944

drivers/net/pasemi_mac.c

+5 −4
Original line number Diff line number Diff line
@@ -1064,11 +1064,12 @@ static int pasemi_mac_open(struct net_device *dev) 
	write_mac_reg(mac, PAS_MAC_CFG_PCFG, flags);



	ret = pasemi_mac_phy_init(dev);

	/* Some configs don't have PHYs (XAUI etc), so don't complain about

	 * failed init due to -ENODEV.

	/* Warn for missing PHY on SGMII (1Gig) ports.

	 */

	if (ret && ret != -ENODEV)

		dev_warn(&mac->pdev->dev, "phy init failed: %d\n", ret);

	if (ret && mac->type == MAC_TYPE_GMAC) {

		dev_warn(&mac->pdev->dev, "PHY init failed: %d.\n", ret);

		dev_warn(&mac->pdev->dev, "Defaulting to 1Gbit full duplex\n");

	}



	netif_start_queue(dev);

	napi_enable(&mac->napi);