Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82ff1f5c authored by Abhijeet Dharmapurikar's avatar Abhijeet Dharmapurikar Committed by David Collins
Browse files

spmi: regmap: enable userspace writes 



Being able to write to spmi registers via userspace is required
for quick debug and development. Enable it.

The regmap framework uses dev_name to create debugfs dir names.
So update the spmi devices to have proper names.

Change-Id: I8a5da203b212df9a7f1410e3fcf6ee7b429856b6
Signed-off-by: default avatarAbhijeet Dharmapurikar <adharmap@codeaurora.org>
parent c7af376e

drivers/base/regmap/regmap-debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ static ssize_t regmap_map_read_file(struct file *file, char __user *user_buf, 
				   count, ppos);

}



#undef REGMAP_ALLOW_WRITE_DEBUGFS

#define REGMAP_ALLOW_WRITE_DEBUGFS

#ifdef REGMAP_ALLOW_WRITE_DEBUGFS

/*

 * This can be dangerous especially when we have clients such as

drivers/spmi/spmi.c

+4 −13
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and

 * only version 2 as published by the Free Software Foundation.

 *

 * This program is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of

 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

 * GNU General Public License for more details.

 */

// SPDX-License-Identifier: GPL-2.0

/* Copyright (c) 2012-2016, The Linux Foundation. All rights reserved. */



#include <linux/kernel.h>

#include <linux/errno.h>

#include <linux/idr.h>
@@ -70,7 +61,7 @@ int spmi_device_add(struct spmi_device *sdev) 
	struct spmi_controller *ctrl = sdev->ctrl;

	int err;



	dev_set_name(&sdev->dev, "%d-%02x", ctrl->nr, sdev->usid);

	dev_set_name(&sdev->dev, "spmi%d-%02x", ctrl->nr, sdev->usid);



	err = device_add(&sdev->dev);

	if (err < 0) {