Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82c084f5 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: phy: bcm7xxx: remove suspend callback for 28nm PHYs 



BCM7xxx internal Gigabit PHY on 28nm process do not need anything
special to be done during suspend, remove the suspend callback since it
might be harmful rather than useful. While at it, update the comment
above bcm7xxx_suspend() to reflect that it applies only to 40nm and 65nm
process PHY devices.

Fixes: b560a58c ("net: phy: add Broadcom BCM7xxx internal PHY driver")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@greenl8ke.davemloft.net>
parent 4fd14e0b

drivers/net/phy/bcm7xxx.c

+1 −4
Original line number Diff line number Diff line
@@ -229,7 +229,7 @@ static int bcm7xxx_config_init(struct phy_device *phydev) 
}



/* Workaround for putting the PHY in IDDQ mode, required

 * for all BCM7XXX PHYs

 * for all BCM7XXX 40nm and 65nm PHYs

 */

static int bcm7xxx_suspend(struct phy_device *phydev)

{
@@ -274,7 +274,6 @@ static struct phy_driver bcm7xxx_driver[] = { 
	.config_init	= bcm7xxx_28nm_afe_config_init,

	.config_aneg	= genphy_config_aneg,

	.read_status	= genphy_read_status,

	.suspend	= bcm7xxx_suspend,

	.resume		= bcm7xxx_28nm_resume,

	.driver		= { .owner = THIS_MODULE },

}, {
@@ -287,7 +286,6 @@ static struct phy_driver bcm7xxx_driver[] = { 
	.config_init	= bcm7xxx_28nm_afe_config_init,

	.config_aneg	= genphy_config_aneg,

	.read_status	= genphy_read_status,

	.suspend	= bcm7xxx_suspend,

	.resume		= bcm7xxx_28nm_resume,

	.driver		= { .owner = THIS_MODULE },

}, {
@@ -300,7 +298,6 @@ static struct phy_driver bcm7xxx_driver[] = { 
	.config_init	= bcm7xxx_28nm_config_init,

	.config_aneg	= genphy_config_aneg,

	.read_status	= genphy_read_status,

	.suspend	= bcm7xxx_suspend,

	.resume		= bcm7xxx_28nm_afe_config_init,

	.driver		= { .owner = THIS_MODULE },

}, {