Commit 82a820e8 authored Aug 16, 2012 by Julia Lawall Committed by David S. Miller Aug 20, 2012

drivers/net/wimax/i2400m/fw.c: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret;
expression e1,e2;
@@

if (ret < 0)
 { ... return ret; }
 ... when != ret = e1
     when forall
*if(...)
 {
  ... when != ret = e2
* return ret;
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b3f0db1c

drivers/net/wimax/i2400m/fw.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -326,8 +326,10 @@ int i2400m_barker_db_init(const char *_options)
		unsigned barker;

		options_orig = kstrdup(_options, GFP_KERNEL);
		if (options_orig == NULL)
		if (options_orig == NULL) {
		result = -ENOMEM;
		goto error_parse;
		}
		options = options_orig;

		while ((token = strsep(&options, ",")) != NULL) {