Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82266e98 authored Apr 24, 2018 by NeilBrown Committed by David S. Miller Apr 24, 2018

rhashtable: Revise incorrect comment on r{hl, hash}table_walk_enter()



Neither rhashtable_walk_enter() or rhltable_walk_enter() sleep, though
they do take a spinlock without irq protection.
So revise the comments to accurately state the contexts in which
these functions can be called.

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0c6f69a5

include/linux/rhashtable.h

+3 −2

Original line number	Diff line number	Diff line
		@@ -1268,8 +1268,9 @@ static inline int rhashtable_walk_init(struct rhashtable *ht,
		* For a completely stable walk you should construct your own data
		* structure outside the hash table.
		*
		* This function may sleep so you must not call it from interrupt
		* context or with spin locks held.
		* This function may be called from any process context, including
		* non-preemptable context, but cannot be called from softirq or
		* hardirq context.
		*
		* You must call rhashtable_walk_exit after this function returns.
		*/

lib/rhashtable.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -668,8 +668,9 @@ EXPORT_SYMBOL_GPL(rhashtable_insert_slow);
		* For a completely stable walk you should construct your own data
		* structure outside the hash table.
		*
		* This function may sleep so you must not call it from interrupt
		* context or with spin locks held.
		* This function may be called from any process context, including
		* non-preemptable context, but cannot be called from softirq or
		* hardirq context.
		*
		* You must call rhashtable_walk_exit after this function returns.
		*/