Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8208b28a authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Krzysztof Kozlowski
Browse files

pinctrl: samsung: Clean up modular vs. non-modular distinctions 



Fixups here tend to be more all over the map vs. some of the other
repeated/systematic ones we've seen elsewhere.

We remove module.h from code that isn't doing anything modular at
all;  if they have __init sections, then replace it with init.h

A couple drivers have module_exit() code that is essentially orphaned,
and so we remove that.

There are no module_init replacements, so we have no concerns wrt.
initcall ordering changes as per some of the other cleanups.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
parent 7ddaa43e

drivers/pinctrl/samsung/pinctrl-exynos.c

+0 −1
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ 
 * external gpio and wakeup interrupt support.

 */



#include <linux/module.h>

#include <linux/device.h>

#include <linux/interrupt.h>

#include <linux/irqdomain.h>

drivers/pinctrl/samsung/pinctrl-exynos5440.c

+3 −12
Original line number Diff line number Diff line 
/*

 * pin-controller/pin-mux/pin-config/gpio-driver for Samsung's EXYNOS5440 SoC.

 *

 * Author: Thomas Abraham <thomas.ab@samsung.com>

 *

 * Copyright (c) 2012 Samsung Electronics Co., Ltd.

 *		http://www.samsung.com

 *
@@ -10,7 +12,7 @@ 
 * (at your option) any later version.

 */



#include <linux/module.h>

#include <linux/init.h>

#include <linux/platform_device.h>

#include <linux/io.h>

#include <linux/slab.h>
@@ -991,7 +993,6 @@ static const struct of_device_id exynos5440_pinctrl_dt_match[] = { 
	{ .compatible = "samsung,exynos5440-pinctrl" },

	{},

};

MODULE_DEVICE_TABLE(of, exynos5440_pinctrl_dt_match);



static struct platform_driver exynos5440_pinctrl_driver = {

	.probe		= exynos5440_pinctrl_probe,
@@ -1007,13 +1008,3 @@ static int __init exynos5440_pinctrl_drv_register(void) 
	return platform_driver_register(&exynos5440_pinctrl_driver);

}

postcore_initcall(exynos5440_pinctrl_drv_register);
 


static void __exit exynos5440_pinctrl_drv_unregister(void)

{

	platform_driver_unregister(&exynos5440_pinctrl_driver);

}

module_exit(exynos5440_pinctrl_drv_unregister);



MODULE_AUTHOR("Thomas Abraham <thomas.ab@samsung.com>");

MODULE_DESCRIPTION("Samsung EXYNOS5440 SoC pinctrl driver");

MODULE_LICENSE("GPL v2");

drivers/pinctrl/samsung/pinctrl-s3c24xx.c

+1 −1
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ 
 * external gpio and wakeup interrupt support.

 */



#include <linux/module.h>

#include <linux/init.h>

#include <linux/device.h>

#include <linux/interrupt.h>

#include <linux/irqdomain.h>

drivers/pinctrl/samsung/pinctrl-s3c64xx.c

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 
 * external gpio and wakeup interrupt support.

 */



#include <linux/module.h>

#include <linux/init.h>

#include <linux/device.h>

#include <linux/interrupt.h>

#include <linux/irqdomain.h>

drivers/pinctrl/samsung/pinctrl-samsung.c

+1 −12
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ 
 * and wakeup interrupts can be hooked to.

 */



#include <linux/module.h>

#include <linux/init.h>

#include <linux/platform_device.h>

#include <linux/io.h>

#include <linux/slab.h>
@@ -1221,7 +1221,6 @@ static const struct of_device_id samsung_pinctrl_dt_match[] = { 
#endif

	{},

};

MODULE_DEVICE_TABLE(of, samsung_pinctrl_dt_match);



static const struct dev_pm_ops samsung_pinctrl_pm_ops = {

	SET_LATE_SYSTEM_SLEEP_PM_OPS(samsung_pinctrl_suspend,
@@ -1243,13 +1242,3 @@ static int __init samsung_pinctrl_drv_register(void) 
	return platform_driver_register(&samsung_pinctrl_driver);

}

postcore_initcall(samsung_pinctrl_drv_register);
 


static void __exit samsung_pinctrl_drv_unregister(void)

{

	platform_driver_unregister(&samsung_pinctrl_driver);

}

module_exit(samsung_pinctrl_drv_unregister);



MODULE_AUTHOR("Thomas Abraham <thomas.ab@samsung.com>");

MODULE_DESCRIPTION("Samsung pinctrl driver");

MODULE_LICENSE("GPL v2");