Commit 81da1314 authored Mar 27, 2019 by Jakub Kicinski Committed by Greg Kroah-Hartman Apr 17, 2019

nfp: validate the return code from dev_queue_xmit()



[ Upstream commit c8ba5b91a04e3e2643e48501c114108802f21cda ]

dev_queue_xmit() may return error codes as well as netdev_tx_t,
and it always consumes the skb.  Make sure we always return a
correct netdev_tx_t value.

Fixes: eadfa4c3 ("nfp: add stats and xmit helpers for representors")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c297e881

drivers/net/ethernet/netronome/nfp/nfp_net_repr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -225,7 +225,7 @@ static netdev_tx_t nfp_repr_xmit(struct sk_buff skb, struct net_device netdev)
		ret = dev_queue_xmit(skb);
		nfp_repr_inc_tx_stats(netdev, len, ret);

		return ret;
		return NETDEV_TX_OK;
		}

		static int nfp_repr_stop(struct net_device *netdev)