Commit 81ad2b7d authored Oct 20, 2016 by Wei Yongjun Committed by David S. Miller Oct 20, 2016

net: ethernet: mediatek: use dev_kfree_skb_any instead of dev_kfree_skb



Replace dev_kfree_skb with dev_kfree_skb_any in mtk_start_xmit()
which can be called from hard irq context (netpoll) and from
other contexts. mtk_start_xmit() only frees skbs that it has
dropped.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d80f45ff

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -843,7 +843,7 @@ static int mtk_start_xmit(struct sk_buff skb, struct net_device dev)
		drop:
		spin_unlock(&eth->page_lock);
		stats->tx_dropped++;
		dev_kfree_skb(skb);
		dev_kfree_skb_any(skb);
		return NETDEV_TX_OK;
		}