Commit 815501d0 authored Jun 14, 2020 by Qiushi Wu Committed by Greg Kroah-Hartman Oct 29, 2020

media: s5p-mfc: Fix a reference count leak



[ Upstream commit 78741ce98c2e36188e2343434406b0e0bc50b0e7 ]

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Fixes: c5086f13 ("[media] s5p-mfc: Use clock gating only on MFC v5 hardware")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 766fb941

drivers/media/platform/s5p-mfc/s5p_mfc_pm.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -83,8 +83,10 @@ int s5p_mfc_power_on(void)
	int i, ret = 0;		int i, ret = 0;

	ret = pm_runtime_get_sync(pm->device);		ret = pm_runtime_get_sync(pm->device);
	if (ret < 0)		if (ret < 0) {
			pm_runtime_put_noidle(pm->device);
	return ret;		return ret;
			}

	/* clock control */		/* clock control */
	for (i = 0; i < pm->num_clocks; i++) {		for (i = 0; i < pm->num_clocks; i++) {