Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 813c5b79 authored by Dexuan Cui's avatar Dexuan Cui Committed by Greg Kroah-Hartman
Browse files

hv: vmbus_free_channels(): remove the redundant free_channel() 



free_channel() has been invoked in
vmbus_remove() -> hv_process_channel_removal(), or vmbus_remove() ->
... -> vmbus_close_internal() -> hv_process_channel_removal().

We also change to use list_for_each_entry_safe(), because the entry
is removed in hv_process_channel_removal().

This patch fixes a bug in the vmbus unload path.

Thank Dan Carpenter for finding the issue!

Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 096c605f

drivers/hv/channel_mgmt.c

+8 −3
Original line number Diff line number Diff line
@@ -212,11 +212,16 @@ void hv_process_channel_removal(struct vmbus_channel *channel, u32 relid) 


void vmbus_free_channels(void)

{

	struct vmbus_channel *channel;

	struct vmbus_channel *channel, *tmp;



	list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list,

		listentry) {

		/* if we don't set rescind to true, vmbus_close_internal()

		 * won't invoke hv_process_channel_removal().

		 */

		channel->rescind = true;



	list_for_each_entry(channel, &vmbus_connection.chn_list, listentry) {

		vmbus_device_unregister(channel->device_obj);

		free_channel(channel);

	}

}