Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81050aff authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mauro Carvalho Chehab
Browse files

media: staging: atomisp: Do not set GPIO twice 



gpiod_get() configures GPIO line at the time of successful request.
Thus, no need to do this explicitly.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent e19c9205

drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

+2 −12
Original line number Diff line number Diff line
@@ -409,21 +409,11 @@ static struct gmin_subdev *gmin_subdev_add(struct v4l2_subdev *subdev) 
	if (!ret)

		clk_disable_unprepare(gmin_subdevs[i].pmc_clk);



	if (!IS_ERR(gmin_subdevs[i].gpio0)) {

		ret = gpiod_direction_output(gmin_subdevs[i].gpio0, 0);

		if (ret)

			dev_err(dev, "gpio0 set output failed: %d\n", ret);

	} else {

	if (IS_ERR(gmin_subdevs[i].gpio0))

		gmin_subdevs[i].gpio0 = NULL;

	}



	if (!IS_ERR(gmin_subdevs[i].gpio1)) {

		ret = gpiod_direction_output(gmin_subdevs[i].gpio1, 0);

		if (ret)

			dev_err(dev, "gpio1 set output failed: %d\n", ret);

	} else {

	if (IS_ERR(gmin_subdevs[i].gpio1))

		gmin_subdevs[i].gpio1 = NULL;

	}



	if (pmic_id == PMIC_REGULATOR) {

		gmin_subdevs[i].v1p8_reg = regulator_get(dev, "V1P8SX");