Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8060b8dd authored by Andy Grover's avatar Andy Grover Committed by Nicholas Bellinger
Browse files

iscsi-target: Fix typos in enum cmd_flags_table 



Everything else starts with ICF so the last two should as well.

Fix places they are used to match.

Signed-off-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 2b70e5fd

drivers/target/iscsi/iscsi_target.c

+6 −6
Original line number Diff line number Diff line
@@ -2027,10 +2027,10 @@ iscsit_process_text_cmd(struct iscsi_conn *conn, struct iscsi_cmd *cmd, 
		goto reject;

	}

	if (!strncmp("=All", text_ptr, 4)) {

		cmd->cmd_flags |= IFC_SENDTARGETS_ALL;

		cmd->cmd_flags |= ICF_SENDTARGETS_ALL;

	} else if (!strncmp("=iqn.", text_ptr, 5) ||

		   !strncmp("=eui.", text_ptr, 5)) {

		cmd->cmd_flags |= IFC_SENDTARGETS_SINGLE;

		cmd->cmd_flags |= ICF_SENDTARGETS_SINGLE;

	} else {

		pr_err("Unable to locate valid SendTargets=%s value\n", text_ptr);

		goto reject;
@@ -3415,10 +3415,10 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, 
		return -ENOMEM;

	}

	/*

	 * Locate pointer to iqn./eui. string for IFC_SENDTARGETS_SINGLE

	 * Locate pointer to iqn./eui. string for ICF_SENDTARGETS_SINGLE

	 * explicit case..

	 */

	if (cmd->cmd_flags & IFC_SENDTARGETS_SINGLE) {

	if (cmd->cmd_flags & ICF_SENDTARGETS_SINGLE) {

		text_ptr = strchr(text_in, '=');

		if (!text_ptr) {

			pr_err("Unable to locate '=' string in text_in:"
@@ -3434,7 +3434,7 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, 


	spin_lock(&tiqn_lock);

	list_for_each_entry(tiqn, &g_tiqn_list, tiqn_list) {

		if ((cmd->cmd_flags & IFC_SENDTARGETS_SINGLE) &&

		if ((cmd->cmd_flags & ICF_SENDTARGETS_SINGLE) &&

		     strcmp(tiqn->tiqn, text_ptr)) {

			continue;

		}
@@ -3512,7 +3512,7 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, 
		if (end_of_buf)

			break;



		if (cmd->cmd_flags & IFC_SENDTARGETS_SINGLE)

		if (cmd->cmd_flags & ICF_SENDTARGETS_SINGLE)

			break;

	}

	spin_unlock(&tiqn_lock);

drivers/target/iscsi/iscsi_target_core.h

+2 −2
Original line number Diff line number Diff line
@@ -135,8 +135,8 @@ enum cmd_flags_table { 
	ICF_CONTIG_MEMORY			= 0x00000020,

	ICF_ATTACHED_TO_RQUEUE			= 0x00000040,

	ICF_OOO_CMDSN				= 0x00000080,

	IFC_SENDTARGETS_ALL			= 0x00000100,

	IFC_SENDTARGETS_SINGLE			= 0x00000200,

	ICF_SENDTARGETS_ALL			= 0x00000100,

	ICF_SENDTARGETS_SINGLE			= 0x00000200,

};



/* struct iscsi_cmd->i_state */