Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fbd24e0 authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Greg Kroah-Hartman
Browse files

dmaengine: tegra-apb: Prevent race conditions on channel's freeing 



[ Upstream commit 8e84172e372bdca20c305d92d51d33640d2da431 ]

It's incorrect to check the channel's "busy" state without taking a lock.
That shouldn't cause any real troubles, nevertheless it's always better
not to have any race conditions in the code.

Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20200209163356.6439-5-digetx@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1da6faf4

drivers/dma/tegra20-apb-dma.c

+1 −2
Original line number Diff line number Diff line
@@ -1225,7 +1225,6 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc) 


	dev_dbg(tdc2dev(tdc), "Freeing channel %d\n", tdc->id);



	if (tdc->busy)

	tegra_dma_terminate_all(dc);



	spin_lock_irqsave(&tdc->lock, flags);