Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f8b8f3f authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Martin K. Petersen
Browse files

mpt3sas: Remove unnecessary synchronize_irq() before free_irq() 



Calling synchronize_irq() right before free_irq() is quite useless. On
one hand the IRQ can easily fire again before free_irq() is entered, on
the other hand free_irq() itself calls synchronize_irq() internally (in
a race condition free way), before any state associated with the IRQ is
freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
 free_irq(irq, ...);
// </smpl>

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Acked-by: default avatarSreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 83430833

drivers/scsi/mpt3sas/mpt3sas_base.c

+0 −1
Original line number Diff line number Diff line
@@ -1820,7 +1820,6 @@ _base_free_irq(struct MPT3SAS_ADAPTER *ioc) 
			irq_set_affinity_hint(reply_q->vector, NULL);

			free_cpumask_var(reply_q->affinity_hint);

		}

		synchronize_irq(reply_q->vector);

		free_irq(reply_q->vector, reply_q);

		kfree(reply_q);

	}