Commit 7f53de20 authored May 23, 2017 by Dmitry Torokhov Committed by Greg Kroah-Hartman May 25, 2017

firmware: vpd: do not leave freed section attributes to the list



We should only add section attribute to the list of section attributes
if we successfully created corresponding sysfs attribute.

Fixes: 049a59db ("firmware: Google VPD sysfs driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 08332893

drivers/firmware/google/vpd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -136,12 +136,12 @@ static int vpd_section_attrib_add(const u8 *key, s32 key_len,
		info->value = value;

		INIT_LIST_HEAD(&info->list);
		list_add_tail(&info->list, &sec->attribs);

		ret = sysfs_create_bin_file(sec->kobj, &info->bin_attr);
		if (ret)
		goto free_info_key;

		list_add_tail(&info->list, &sec->attribs);
		return 0;

		free_info_key: