Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7de241f3 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Kalle Valo
Browse files

wlcore: fix unused function warning 



The newly added wlcore_fw_sleep function is called conditionally,
which causes a warning without CONFIG_PM:

drivers/net/wireless/ti/wlcore/main.c:981:12: error: 'wlcore_fw_sleep' defined but not used [-Werror=unused-function]

Instead of trying to keep track of what should be in the #ifdef and what
should not, it's easier to mark the top-level suspend/resume functions
as __maybe_unused so the compiler can silently drop all the unused code.

Fixes: 37bf241b ("wlcore: allow elp during wowlan suspend")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent e4779162

drivers/net/wireless/ti/wlcore/acx.h

+0 −2
Original line number Diff line number Diff line
@@ -1129,10 +1129,8 @@ int wl12xx_acx_config_hangover(struct wl1271 *wl); 
int wlcore_acx_average_rssi(struct wl1271 *wl, struct wl12xx_vif *wlvif,

			    s8 *avg_rssi);



#ifdef CONFIG_PM

int wl1271_acx_default_rx_filter_enable(struct wl1271 *wl, bool enable,

					enum rx_filter_action action);

int wl1271_acx_set_rx_filter(struct wl1271 *wl, u8 index, bool enable,

			     struct wl12xx_rx_filter *filter);

#endif /* CONFIG_PM */

#endif /* __WL1271_ACX_H__ */

drivers/net/wireless/ti/wlcore/main.c

+3 −5
Original line number Diff line number Diff line
@@ -1343,7 +1343,6 @@ static struct sk_buff *wl12xx_alloc_dummy_packet(struct wl1271 *wl) 
}





#ifdef CONFIG_PM

static int

wl1271_validate_wowlan_pattern(struct cfg80211_pkt_pattern *p)

{
@@ -1715,7 +1714,7 @@ static void wl1271_configure_resume(struct wl1271 *wl, struct wl12xx_vif *wlvif) 
	}

}



static int wl1271_op_suspend(struct ieee80211_hw *hw,

static int __maybe_unused wl1271_op_suspend(struct ieee80211_hw *hw,

					    struct cfg80211_wowlan *wow)

{

	struct wl1271 *wl = hw->priv;
@@ -1810,7 +1809,7 @@ static int wl1271_op_suspend(struct ieee80211_hw *hw, 
	return 0;

}



static int wl1271_op_resume(struct ieee80211_hw *hw)

static int __maybe_unused wl1271_op_resume(struct ieee80211_hw *hw)

{

	struct wl1271 *wl = hw->priv;

	struct wl12xx_vif *wlvif;
@@ -1894,7 +1893,6 @@ static int wl1271_op_resume(struct ieee80211_hw *hw) 


	return 0;

}

#endif



static int wl1271_op_start(struct ieee80211_hw *hw)

{