Commit 7dad9ef6 authored Feb 02, 2010 by Julia Lawall Committed by Ben Skeggs Feb 09, 2010

drivers/gpu/drm/nouveau/nouveau_grctx.c: correct NULL test

Test the just-allocated value for NULL rather than some other value.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,y;
statement S;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
-   y
+   x
       == NULL)
 S
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: David Airlie <airlied@linux.ie>
Cc: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent f0fbe3eb

drivers/gpu/drm/nouveau/nouveau_grctx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -97,8 +97,8 @@ nouveau_grctx_prog_load(struct drm_device *dev)
		}

		pgraph->ctxvals = kmalloc(fw->size, GFP_KERNEL);
		if (!pgraph->ctxprog) {
		NV_ERROR(dev, "OOM copying ctxprog\n");
		if (!pgraph->ctxvals) {
		NV_ERROR(dev, "OOM copying ctxvals\n");
		release_firmware(fw);
		nouveau_grctx_fini(dev);
		return -ENOMEM;