Commit 7d9b8ab3 authored Nov 09, 2020 by Qinglang Miao Committed by Greg Kroah-Hartman Dec 30, 2020

scsi: qedi: Fix missing destroy_workqueue() on error in __qedi_probe

[ Upstream commit 62eebd5247c4e4ce08826ad5995cf4dd7ce919dd ]

Add the missing destroy_workqueue() before return from __qedi_probe in the
error handling case when fails to create workqueue qedi->offload_thread.

Link: https://lore.kernel.org/r/20201109091518.55941-1-miaoqinglang@huawei.com


Fixes: ace7f46b ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 163426bf

drivers/scsi/qedi/qedi_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2580,7 +2580,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
		QEDI_ERR(&qedi->dbg_ctx,
		"Unable to start offload thread!\n");
		rc = -ENODEV;
		goto free_cid_que;
		goto free_tmf_thread;
		}

		/* F/w needs 1st task context memory entry for performance */
		@@ -2600,6 +2600,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)

		return 0;

		free_tmf_thread:
		destroy_workqueue(qedi->tmf_thread);
		free_cid_que:
		qedi_release_cid_que(qedi);
		free_uio: