Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 7d800c99 authored by Enric Balletbo i Serra's avatar Enric Balletbo i Serra Committed by Benson Leung
Browse files

platform/chrome: cros_ec_sysfs: use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR variants for read/write attributes. This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.

Suggested-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarBenson Leung <bleung@chromium.org>
parent 93afebbe

drivers/platform/chrome/cros_ec_sysfs.c

+12 −12
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ 


/* Accessor functions */



static ssize_t show_ec_reboot(struct device *dev,

static ssize_t reboot_show(struct device *dev,

			   struct device_attribute *attr, char *buf)

{

	int count = 0;
@@ -50,7 +50,7 @@ static ssize_t show_ec_reboot(struct device *dev, 
	return count;

}



static ssize_t store_ec_reboot(struct device *dev,

static ssize_t reboot_store(struct device *dev,

			    struct device_attribute *attr,

			    const char *buf, size_t count)

{
@@ -123,7 +123,7 @@ static ssize_t store_ec_reboot(struct device *dev, 
	return count;

}



static ssize_t show_ec_version(struct device *dev,

static ssize_t version_show(struct device *dev,

			    struct device_attribute *attr, char *buf)

{

	static const char * const image_names[] = {"unknown", "RO", "RW"};
@@ -225,7 +225,7 @@ static ssize_t show_ec_version(struct device *dev, 
	return count;

}



static ssize_t show_ec_flashinfo(struct device *dev,

static ssize_t flashinfo_show(struct device *dev,

			      struct device_attribute *attr, char *buf)

{

	struct ec_response_flash_info *resp;
@@ -260,9 +260,9 @@ static ssize_t show_ec_flashinfo(struct device *dev, 


/* Module initialization */



static DEVICE_ATTR(reboot, S_IWUSR | S_IRUGO, show_ec_reboot, store_ec_reboot);

static DEVICE_ATTR(version, S_IRUGO, show_ec_version, NULL);

static DEVICE_ATTR(flashinfo, S_IRUGO, show_ec_flashinfo, NULL);

static DEVICE_ATTR_RW(reboot);

static DEVICE_ATTR_RO(version);

static DEVICE_ATTR_RO(flashinfo);



static struct attribute *__ec_attrs[] = {

	&dev_attr_reboot.attr,