Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d3d6e06 authored by Vinod Koul's avatar Vinod Koul Committed by Mark Brown
Browse files

ASoC: Intel: Skylake: Remove driver debugfs exit 



For driver debugfs, debugfs_remove_recursive() is called which is not
needed as it is already done in ASoC core debugfs. And a device managed
memory need not be freed explicitly as device core frees it up. So
remove unnecessary skl_debugfs_exit().

Fixes: 5cdf6c09 ASoC: ("Intel: Skylake: Add debugfs support")
Reported-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarGuneshwor Singh <guneshwor.o.singh@intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 58be7753

sound/soc/intel/skylake/skl-debug.c

+0 −8
Original line number Diff line number Diff line
@@ -259,11 +259,3 @@ struct skl_debug *skl_debugfs_init(struct skl *skl) 
	debugfs_remove_recursive(d->fs);

	return NULL;

}
 


void skl_debugfs_exit(struct skl_debug *d)

{

	debugfs_remove_recursive(d->fs);



	kfree(d);



}

sound/soc/intel/skylake/skl.c

+0 −1
Original line number Diff line number Diff line
@@ -866,7 +866,6 @@ static void skl_remove(struct pci_dev *pci) 
	/* codec removal, invoke bus_device_remove */

	snd_hdac_ext_bus_device_remove(ebus);



	skl_debugfs_exit(skl->debugfs);

	skl->debugfs = NULL;

	skl_platform_unregister(&pci->dev);

	skl_free_dsp(skl);

sound/soc/intel/skylake/skl.h

+0 −3
Original line number Diff line number Diff line
@@ -125,7 +125,6 @@ struct skl_module_cfg; 


#ifdef CONFIG_DEBUG_FS

struct skl_debug *skl_debugfs_init(struct skl *skl);

void skl_debugfs_exit(struct skl_debug *d);

void skl_debug_init_module(struct skl_debug *d,

			struct snd_soc_dapm_widget *w,

			struct skl_module_cfg *mconfig);
@@ -134,8 +133,6 @@ static inline struct skl_debug *skl_debugfs_init(struct skl *skl) 
{

	return NULL;

}

static inline void skl_debugfs_exit(struct skl_debug *d)

{}

static inline void skl_debug_init_module(struct skl_debug *d,

					 struct snd_soc_dapm_widget *w,

					 struct skl_module_cfg *mconfig)