Commit 7d225368 authored Nov 05, 2017 by Nikita Leshenko Committed by Paolo Bonzini Nov 17, 2017

KVM: x86: ioapic: Remove redundant check for Remote IRR in ioapic_set_irq



Remote IRR for level-triggered interrupts was previously checked in
ioapic_set_irq, but since we now have a check in ioapic_service we
can remove the redundant check from ioapic_set_irq.

This commit doesn't change semantics.

Signed-off-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
Reviewed-by: Liran Alon <liran.alon@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Wanpeng Li <wanpeng.li@hotmail.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent da3fe7bd

arch/x86/kvm/ioapic.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -209,13 +209,13 @@ static int ioapic_set_irq(struct kvm_ioapic *ioapic, unsigned int irq,

		old_irr = ioapic->irr;
		ioapic->irr \|= mask;
		if (edge)
		if (edge) {
		ioapic->irr_delivered &= ~mask;
		if ((edge && old_irr == ioapic->irr) \|\|
		(!edge && entry.fields.remote_irr)) {
		if (old_irr == ioapic->irr) {
		ret = 0;
		goto out;
		}
		}

		ret = ioapic_service(ioapic, irq, line_status);