Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d1a99da authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: tlv320aic3x: Remove unnecessary suspend/resume bias level changes 



The ASoC core will only call the suspend/resume callbacks when the device's
DAPM context is idle. Since this driver sets idle_bias_off to true this
means that the device is already in SND_SOC_BIAS_OFF when the suspend
callback is called, so there is no need to manually set this state again.
There is also no need to go to SND_SOC_BIAS_STANDBY in the resume callback
since the core will go right back to SND_SOC_BIAS_OFF.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8e6fe35e

sound/soc/codecs/tlv320aic3x.c

+0 −16
Original line number Diff line number Diff line
@@ -1222,20 +1222,6 @@ static struct snd_soc_dai_driver aic3x_dai = { 
	.symmetric_rates = 1,

};



static int aic3x_suspend(struct snd_soc_codec *codec)

{

	aic3x_set_bias_level(codec, SND_SOC_BIAS_OFF);



	return 0;

}



static int aic3x_resume(struct snd_soc_codec *codec)

{

	aic3x_set_bias_level(codec, SND_SOC_BIAS_STANDBY);



	return 0;

}



static void aic3x_mono_init(struct snd_soc_codec *codec)

{

	/* DAC to Mono Line Out default volume and route to Output mixer */
@@ -1429,8 +1415,6 @@ static struct snd_soc_codec_driver soc_codec_dev_aic3x = { 
	.idle_bias_off = true,

	.probe = aic3x_probe,

	.remove = aic3x_remove,

	.suspend = aic3x_suspend,

	.resume = aic3x_resume,

	.controls = aic3x_snd_controls,

	.num_controls = ARRAY_SIZE(aic3x_snd_controls),

	.dapm_widgets = aic3x_dapm_widgets,