Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cef45da authored by Nilaan Gunabalachandran's avatar Nilaan Gunabalachandran
Browse files

drm: factor out drm_close_helper() function 



Will be used to plug an existing memory leak.

Change-Id: I7f482c6ae3db07301dee27158d9b6d7a5aa5a93e
Signed-off-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190114084410.15266-1-emil.l.velikov@gmail.com
Git-commit: e21710a893c8705360b764fa44061d72d65fb2ae
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarNilaan Gunabalachandran <ngunabal@codeaurora.org>
parent 30d171ac

drivers/gpu/drm/drm_file.c

+13 −5
Original line number Diff line number Diff line
@@ -264,6 +264,18 @@ void drm_file_free(struct drm_file *file) 
	kfree(file);

}



static void drm_close_helper(struct file *filp)

{

	struct drm_file *file_priv = filp->private_data;

	struct drm_device *dev = file_priv->minor->dev;



	mutex_lock(&dev->filelist_mutex);

	list_del(&file_priv->lhead);

	mutex_unlock(&dev->filelist_mutex);



	drm_file_free(file_priv);

}



static int drm_setup(struct drm_device * dev)

{

	int ret;
@@ -480,11 +492,7 @@ int drm_release(struct inode *inode, struct file *filp) 


	DRM_DEBUG("open_count = %d\n", dev->open_count);



	mutex_lock(&dev->filelist_mutex);

	list_del(&file_priv->lhead);

	mutex_unlock(&dev->filelist_mutex);



	drm_file_free(file_priv);

	drm_close_helper(filp);



	if (!--dev->open_count)

		drm_lastclose(dev);