Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cace978 authored by Hans de Goede's avatar Hans de Goede Committed by Sarah Sharp
Browse files

uas: Remove comment about registering a uas scsi controller for each usb bus



Although an interesting concept, I don't think that this is a good idea:

-This will result in lots of "virtual" scsi controllers confusing users
-If we get a scsi-bus-reset we will now need to do a usb-device-reset of all
 uas devices on the same usb bus, which is something to avoid if possible

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
parent f50a4968
Loading
Loading
Loading
Loading
+0 −6
Original line number Diff line number Diff line
@@ -1050,12 +1050,6 @@ static void uas_free_streams(struct uas_dev_info *devinfo)
	usb_free_streams(devinfo->intf, eps, 3, GFP_KERNEL);
}

/*
 * XXX: What I'd like to do here is register a SCSI host for each USB host in
 * the system.  Follow usb-storage's design of registering a SCSI host for
 * each USB device for the moment.  Can implement this by walking up the
 * USB hierarchy until we find a USB host.
 */
static int uas_probe(struct usb_interface *intf, const struct usb_device_id *id)
{
	int result = -ENOMEM;