Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c9d8d0c authored by Bryant G. Ly's avatar Bryant G. Ly Committed by Bart Van Assche
Browse files

ibmvscsis: Fix srp_transfer_data fail return code 



If srp_transfer_data fails within ibmvscsis_write_pending, then
the most likely scenario is that the client timed out the op and
removed the TCE mapping. Thus it will loop forever retrying the
op that is pretty much guaranteed to fail forever. A better return
code would be EIO instead of EAGAIN.

Cc: stable@vger.kernel.org
Reported-by: default avatarSteven Royer <seroyer@linux.vnet.ibm.com>
Tested-by: default avatarSteven Royer <seroyer@linux.vnet.ibm.com>
Signed-off-by: default avatarBryant G. Ly <bgly@us.ibm.com>
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
parent 87156518

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c

+1 −1
Original line number Diff line number Diff line
@@ -3585,7 +3585,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd) 
			       1, 1);

	if (rc) {

		pr_err("srp_transfer_data() failed: %d\n", rc);

		return -EAGAIN;

		return -EIO;

	}

	/*

	 * We now tell TCM to add this WRITE CDB directly into the TCM storage