Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bd17592 authored by Alexander Duyck's avatar Alexander Duyck Committed by Jeff Kirsher
Browse files

igb: Add support for DMA_ATTR_WEAK_ORDERING 



Since we are already using DMA attributes in igb for Rx there is no reason
why we can't also apply DMA_ATTR_WEAK_ORDERING which is needed on some
platforms to improve performance.

Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent fe723dff

drivers/net/ethernet/intel/igb/igb.h

+3 −0
Original line number Diff line number Diff line
@@ -148,6 +148,9 @@ struct vf_data_storage { 
/* How many Rx Buffers do we bundle into one write to the hardware ? */

#define IGB_RX_BUFFER_WRITE	16 /* Must be power of 2 */



#define IGB_RX_DMA_ATTR \

	(DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING)



#define AUTO_ALL_MODES		0

#define IGB_EEPROM_APME		0x0400

drivers/net/ethernet/intel/igb/igb_main.c

+3 −3
Original line number Diff line number Diff line
@@ -3963,7 +3963,7 @@ static void igb_clean_rx_ring(struct igb_ring *rx_ring) 
				     buffer_info->dma,

				     PAGE_SIZE,

				     DMA_FROM_DEVICE,

				     DMA_ATTR_SKIP_CPU_SYNC);

				     IGB_RX_DMA_ATTR);

		__page_frag_cache_drain(buffer_info->page,

					buffer_info->pagecnt_bias);
@@ -6990,7 +6990,7 @@ static struct sk_buff *igb_fetch_rx_buffer(struct igb_ring *rx_ring, 
		 */

		dma_unmap_page_attrs(rx_ring->dev, rx_buffer->dma,

				     PAGE_SIZE, DMA_FROM_DEVICE,

				     DMA_ATTR_SKIP_CPU_SYNC);

				     IGB_RX_DMA_ATTR);

		__page_frag_cache_drain(page, rx_buffer->pagecnt_bias);

	}
@@ -7250,7 +7250,7 @@ static bool igb_alloc_mapped_page(struct igb_ring *rx_ring, 


	/* map page for use */

	dma = dma_map_page_attrs(rx_ring->dev, page, 0, PAGE_SIZE,

				 DMA_FROM_DEVICE, DMA_ATTR_SKIP_CPU_SYNC);

				 DMA_FROM_DEVICE, IGB_RX_DMA_ATTR);



	/* if mapping failed free memory back to system since

	 * there isn't much point in holding memory we can't use