Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b69549a authored by David S. Miller's avatar David S. Miller
Browse files

ath6kl: Stop using NLA_PUT*(). 



These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 61849dda

drivers/net/wireless/ath/ath6kl/testmode.c

+3 −2
Original line number Diff line number Diff line
@@ -55,8 +55,9 @@ void ath6kl_tm_rx_event(struct ath6kl *ar, void *buf, size_t buf_len) 
		ath6kl_warn("failed to allocate testmode rx skb!\n");

		return;

	}

	NLA_PUT_U32(skb, ATH6KL_TM_ATTR_CMD, ATH6KL_TM_CMD_TCMD);

	NLA_PUT(skb, ATH6KL_TM_ATTR_DATA, buf_len, buf);

	if (nla_put_u32(skb, ATH6KL_TM_ATTR_CMD, ATH6KL_TM_CMD_TCMD) ||

	    nla_put(skb, ATH6KL_TM_ATTR_DATA, buf_len, buf))

		goto nla_put_failure;

	cfg80211_testmode_event(skb, GFP_KERNEL);

	return;