Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ac65007 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Martin K. Petersen
Browse files

scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() 



Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as
fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ
that ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the
FC_RQST_STATE_DONE flag.

Signed-off-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 1d69b122

drivers/scsi/libfc/fc_lport.c

+0 −2
Original line number Diff line number Diff line
@@ -1912,7 +1912,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, 
		bsg_reply->result = (PTR_ERR(fp) == -FC_EX_CLOSED) ?

			-ECONNABORTED : -ETIMEDOUT;

		job->reply_len = sizeof(uint32_t);

		job->state_flags |= FC_RQST_STATE_DONE;

		fc_bsg_jobdone(job, bsg_reply->result,

			       bsg_reply->reply_payload_rcv_len);

		kfree(info);
@@ -1948,7 +1947,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, 
			bsg_reply->reply_payload_rcv_len =

				job->reply_payload.payload_len;

		bsg_reply->result = 0;

		job->state_flags |= FC_RQST_STATE_DONE;

		fc_bsg_jobdone(job, bsg_reply->result,

			       bsg_reply->reply_payload_rcv_len);

		kfree(info);