Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a3f4b48 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: pxa: poodle: Fix enum ctl accesses in a wrong type 



"Jack Function" and "Speaker Function" ctls in poodle are enum, while
the current driver accesses wrongly via value.integer.value[].  They
have to be via value.enumerated.item[] instead.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 127ee199

sound/soc/pxa/poodle.c

+6 −6
Original line number Diff line number Diff line
@@ -138,7 +138,7 @@ static struct snd_soc_ops poodle_ops = { 
static int poodle_get_jack(struct snd_kcontrol *kcontrol,

	struct snd_ctl_elem_value *ucontrol)

{

	ucontrol->value.integer.value[0] = poodle_jack_func;

	ucontrol->value.enumerated.item[0] = poodle_jack_func;

	return 0;

}
@@ -147,10 +147,10 @@ static int poodle_set_jack(struct snd_kcontrol *kcontrol, 
{

	struct snd_soc_card *card =  snd_kcontrol_chip(kcontrol);



	if (poodle_jack_func == ucontrol->value.integer.value[0])

	if (poodle_jack_func == ucontrol->value.enumerated.item[0])

		return 0;



	poodle_jack_func = ucontrol->value.integer.value[0];

	poodle_jack_func = ucontrol->value.enumerated.item[0];

	poodle_ext_control(&card->dapm);

	return 1;

}
@@ -158,7 +158,7 @@ static int poodle_set_jack(struct snd_kcontrol *kcontrol, 
static int poodle_get_spk(struct snd_kcontrol *kcontrol,

	struct snd_ctl_elem_value *ucontrol)

{

	ucontrol->value.integer.value[0] = poodle_spk_func;

	ucontrol->value.enumerated.item[0] = poodle_spk_func;

	return 0;

}
@@ -167,10 +167,10 @@ static int poodle_set_spk(struct snd_kcontrol *kcontrol, 
{

	struct snd_soc_card *card =  snd_kcontrol_chip(kcontrol);



	if (poodle_spk_func == ucontrol->value.integer.value[0])

	if (poodle_spk_func == ucontrol->value.enumerated.item[0])

		return 0;



	poodle_spk_func = ucontrol->value.integer.value[0];

	poodle_spk_func = ucontrol->value.enumerated.item[0];

	poodle_ext_control(&card->dapm);

	return 1;

}