Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a3b6843 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

netrom: info leak in ->getname() 



The sockaddr_ax25 struct has a 3 byte hole between ->sax25_call and
->sax25_ndigis.  I've added a memset to avoid leaking uninitialized
stack data to userspace.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarRalf Baechle <ralf@linux-mips.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fccc9f1f

net/netrom/af_netrom.c

+2 −0
Original line number Diff line number Diff line
@@ -834,6 +834,8 @@ static int nr_getname(struct socket *sock, struct sockaddr *uaddr, 
	struct sock *sk = sock->sk;

	struct nr_sock *nr = nr_sk(sk);



	memset(&sax->fsa_ax25, 0, sizeof(struct sockaddr_ax25));



	lock_sock(sk);

	if (peer != 0) {

		if (sk->sk_state != TCP_ESTABLISHED) {