Unverified Commit 7a3a6323 authored Apr 09, 2018 by Jia-Ju Bai Committed by Mark Brown Apr 16, 2018

ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe



snd_byt_rt5640_mc_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
snd_byt_rt5640_mc_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 270e1ad6

sound/soc/intel/boards/bytcr_rt5640.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -744,7 +744,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
	int i;		int i;

	is_bytcr = false;		is_bytcr = false;
	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC);		priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
	if (!priv)		if (!priv)
	return -ENOMEM;		return -ENOMEM;