Commit 7a36a752 authored Jul 04, 2008 by Oleg Nesterov Committed by Linus Torvalds Jul 04, 2008

get_user_pages(): fix possible page leak on oom



get_user_pages() must not return the error when i != 0.  When pages !=
NULL we have i get_page()'ed pages.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7ca796f4

mm/memory.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1151,7 +1151,7 @@ int get_user_pages(struct task_struct tsk, struct mm_struct mm,
		* be processed until returning to user space.
		*/
		if (unlikely(test_tsk_thread_flag(tsk, TIF_MEMDIE)))
		return -ENOMEM;
		return i ? i : -ENOMEM;

		if (write)
		foll_flags \|= FOLL_WRITE;