Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Snippets Groups Projects
Commit 79c70c30 authored by Jonathan Corbet's avatar Jonathan Corbet
Browse files

docs: Remove space-before-label guidance from CodingStyle


Recent discussion has made it clear that there is no community consensus on
this particular rule.  Remove it now, lest it inspire yet another set of
unwanted "cleanup" patches.

This partially reverts 865a1caa (CodingStyle: Clarify and complete
chapter 7).

Cc: Jean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
parent dca22a63
No related branches found
No related tags found
No related merge requests found
...@@ -451,9 +451,6 @@ Avoid using GW-BASIC names like ``err1:`` and ``err2:``, as you would have to ...@@ -451,9 +451,6 @@ Avoid using GW-BASIC names like ``err1:`` and ``err2:``, as you would have to
renumber them if you ever add or remove exit paths, and they make correctness renumber them if you ever add or remove exit paths, and they make correctness
difficult to verify anyway. difficult to verify anyway.
It is advised to indent labels with a single space (not tab), so that
``diff -p`` does not confuse labels with functions.
The rationale for using gotos is: The rationale for using gotos is:
- unconditional statements are easier to understand and follow - unconditional statements are easier to understand and follow
...@@ -481,7 +478,7 @@ The rationale for using gotos is: ...@@ -481,7 +478,7 @@ The rationale for using gotos is:
goto out_buffer; goto out_buffer;
} }
... ...
out_free_buffer: out_free_buffer:
kfree(buffer); kfree(buffer);
return result; return result;
} }
...@@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err bugs`` which look like this: ...@@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err bugs`` which look like this:
.. code-block:: c .. code-block:: c
err: err:
kfree(foo->bar); kfree(foo->bar);
kfree(foo); kfree(foo);
return ret; return ret;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment