Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 797f299e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

net: altera: set a couple error code in probe() 



commit badd7857f5c933a3dc34942a2c11d67fdbdc24de upstream.

There are two error paths which accidentally return success instead of
a negative error code.

Fixes: bbd2190c ("Altera TSE: Add main and header file for Altera Ethernet Driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0301ca14

drivers/net/ethernet/altera/altera_tse_main.c

+6 −3
Original line number Diff line number Diff line
@@ -1445,16 +1445,19 @@ static int altera_tse_probe(struct platform_device *pdev) 
		priv->rxdescmem_busaddr = dma_res->start;



	} else {

		ret = -ENODEV;

		goto err_free_netdev;

	}



	if (!dma_set_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask)))

	if (!dma_set_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask))) {

		dma_set_coherent_mask(priv->device,

				      DMA_BIT_MASK(priv->dmaops->dmamask));

	else if (!dma_set_mask(priv->device, DMA_BIT_MASK(32)))

	} else if (!dma_set_mask(priv->device, DMA_BIT_MASK(32))) {

		dma_set_coherent_mask(priv->device, DMA_BIT_MASK(32));

	else

	} else {

		ret = -EIO;

		goto err_free_netdev;

	}



	/* MAC address space */

	ret = request_and_map(pdev, "control_port", &control_port,