Commit 7969e77a authored Jun 17, 2016 by Filipe Manana

Btrfs: send, add missing error check for calls to path_loop()



The function path_loop() can return a negative integer, signaling an
error, 0 if there's no path loop and 1 if there's a path loop. We were
treating any non zero values as meaning that a path loop exists. Fix
this by explicitly checking for errors and gracefully return them to
user space.

Signed-off-by: Filipe Manana <fdmanana@suse.com>

parent 801bec36

fs/btrfs/send.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3200,6 +3200,8 @@ static int apply_dir_move(struct send_ctx sctx, struct pending_dir_move pm)

		sctx->send_progress = sctx->cur_ino + 1;
		ret = path_loop(sctx, name, pm->ino, pm->gen, &ancestor);
		if (ret < 0)
		goto out;
		if (ret) {
		LIST_HEAD(deleted_refs);
		ASSERT(ancestor > BTRFS_FIRST_FREE_OBJECTID);