Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7957b07b authored by Matt Redfearn's avatar Matt Redfearn Committed by Daniel Lezcano
Browse files

clocksource/drivers/mips-gic-timer: Remove pointless irq_save,restore 



The function gic_next_event is always called with interrupts disabled, so
the local_irq_save / local_irq_restore are pointless - remove them.

[Daniel Lezcano: Fixed warning by removing unused variable 'flags']

Signed-off-by: default avatarMatt Redfearn <matt.redfearn@mips.com>
Suggested-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Reported-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent a7fb4577

drivers/clocksource/mips-gic-timer.c

+0 −3
Original line number Diff line number Diff line
@@ -39,16 +39,13 @@ static u64 notrace gic_read_count(void) 


static int gic_next_event(unsigned long delta, struct clock_event_device *evt)

{

	unsigned long flags;

	u64 cnt;

	int res;



	cnt = gic_read_count();

	cnt += (u64)delta;

	local_irq_save(flags);

	write_gic_vl_other(mips_cm_vp_id(cpumask_first(evt->cpumask)));

	write_gic_vo_compare(cnt);

	local_irq_restore(flags);

	res = ((int)(gic_read_count() - cnt) >= 0) ? -ETIME : 0;

	return res;

}