Commit 78f543a9 authored Sep 01, 2014 by Stephan Mueller Committed by Herbert Xu Sep 05, 2014

crypto: drbg - remove check for uninitialized DRBG handle



The drbg_healthcheck() contained a test to call the DRBG with an
uninitialized DRBG cipher handle. As this is an inappropriate use of the
kernel crypto API to try to generate random numbers before
initialization, checks verifying for an initialized DRBG have been
removed in previous patches.

Now, the drbg_healthcheck test must also be removed.

Changes V2: Added patch marker to email subject line.

Signed-off-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent fb38ab4c

crypto/drbg.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -1922,9 +1922,6 @@ static inline int __init drbg_healthcheck_sanity(void)
	/* overflow max addtllen with personalization string */		/* overflow max addtllen with personalization string */
	ret = drbg_instantiate(drbg, &addtl, coreref, pr);		ret = drbg_instantiate(drbg, &addtl, coreref, pr);
	BUG_ON(0 == ret);		BUG_ON(0 == ret);
	/* test uninstantated DRBG */
	len = drbg_generate(drbg, buf, (max_request_bytes + 1), NULL);
	BUG_ON(0 < len);
	/* all tests passed */		/* all tests passed */
	rc = 0;		rc = 0;