Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78bb3949 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

V4L/DVB (7549): em28xx: some small cleanups 



- Remove dead code;
- Fix a few CodingStyle issues;
- Prints frame number, if debug is enabled.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent e0fadfd3

drivers/media/video/em28xx/em28xx-video.c

+4 −11
Original line number Diff line number Diff line
@@ -208,8 +208,6 @@ static void em28xx_copy_video(struct em28xx *dev, 
		else

			lencopy = dev->bytesperline;



		BUG_ON(lencopy <= 0);



		if ((char *)startwrite + lencopy > (char *)outp + buf->vb.size) {

			em28xx_isocdbg("Overflow of %zi bytes past buffer end (2)\n",

				       ((char *)startwrite + lencopy) -
@@ -319,7 +317,6 @@ static inline int em28xx_isoc_copy(struct urb *urb) 


	outp = videobuf_to_vmalloc(&buf->vb);





	for (i = 0; i < urb->number_of_packets; i++) {

		int status = urb->iso_frame_desc[i].status;
@@ -347,11 +344,8 @@ static inline int em28xx_isoc_copy(struct urb *urb) 
		   logic simpler. Impacts of those changes should be evaluated

		 */

		if (p[0] == 0x22 && p[1] == 0x5a) {

			/* FIXME - are the fields the right way around? */

			em28xx_isocdbg("Video frame, length=%i, %s\n", len,

					(p[2] & 1)? "odd" : "even");

			em28xx_isocdbg("Current buffer is: outp = 0x%p,"

				       " len = %i\n", outp, (int)buf->vb.size);

			em28xx_isocdbg("Video frame %d, length=%i, %s\n", p[2],

				       len, (p[2] & 1)? "odd" : "even");



			if (p[2] & 1)

				buf->top_field = 0;
@@ -455,7 +449,6 @@ static void em28xx_uninit_isoc(struct em28xx *dev) 
	em28xx_capture_start(dev, 0);

}





/*

 * Allocate URBs and start IRQ

 */