Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 787e2620 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Sasha Levin
Browse files

serial: 8250_exar: Don't remove GPIO device on suspend 



[ Upstream commit 73b5a5c00be39e23b194bad10e1ea8bb73eee176 ]

It seems a copy&paste mistake that suspend callback removes the GPIO
device. There is no counterpart of this action, means once suspended
there is no more GPIO device available untile full unbind-bind cycle
is performed. Remove suspicious GPIO device removal in suspend.

Fixes: d0aeaa83 ("serial: exar: split out the exar code from 8250_pci")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240219150627.2101198-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 575fe3cc

drivers/tty/serial/8250/8250_exar.c

+1 −4
Original line number Diff line number Diff line
@@ -553,6 +553,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) 
	for (i = 0; i < priv->nr; i++)

		serial8250_unregister_port(priv->line[i]);



	/* Ensure that every init quirk is properly torn down */

	if (priv->board->exit)

		priv->board->exit(pcidev);

}
@@ -567,10 +568,6 @@ static int __maybe_unused exar_suspend(struct device *dev) 
		if (priv->line[i] >= 0)

			serial8250_suspend_port(priv->line[i]);



	/* Ensure that every init quirk is properly torn down */

	if (priv->board->exit)

		priv->board->exit(pcidev);



	return 0;

}