Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77f2c2db authored by Roel Kluin's avatar Roel Kluin Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (12436): stk-webcam: read buffer overflow 



It tested the value of stk_sizes[i].m before checking whether i was in range.

Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDouglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 01a5fd6f

drivers/media/video/stk-webcam.c

+2 −2
Original line number Diff line number Diff line
@@ -1050,8 +1050,8 @@ static int stk_setup_format(struct stk_camera *dev) 
		depth = 1;

	else

		depth = 2;

	while (stk_sizes[i].m != dev->vsettings.mode

			&& i < ARRAY_SIZE(stk_sizes))

	while (i < ARRAY_SIZE(stk_sizes) &&

			stk_sizes[i].m != dev->vsettings.mode)

		i++;

	if (i == ARRAY_SIZE(stk_sizes)) {

		STK_ERROR("Something is broken in %s\n", __func__);