Commit 77717920 authored Mar 10, 2020 by Al Viro Committed by Greg Kroah-Hartman Mar 18, 2020

gfs2_atomic_open(): fix O_EXCL|O_CREAT handling on cold dcache



commit 21039132650281de06a169cbe8a0f7e5c578fd8b upstream.

with the way fs/namei.c:do_last() had been done, ->atomic_open()
instances needed to recognize the case when existing file got
found with O_EXCL|O_CREAT, either by falling back to finish_no_open()
or failing themselves.  gfs2 one didn't.

Fixes: 6d4ade98 (GFS2: Add atomic_open support)
Cc: stable@kernel.org # v3.11
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a8ab0b70

fs/gfs2/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1251,7 +1251,7 @@ static int gfs2_atomic_open(struct inode dir, struct dentry dentry,
		if (!(file->f_mode & FMODE_OPENED))
		return finish_no_open(file, d);
		dput(d);
		return 0;
		return excl && (flags & O_CREAT) ? -EEXIST : 0;
		}

		BUG_ON(d != NULL);